Skip to content

Conversation

@ncoghlan
Copy link
Contributor

No description provided.

@ncoghlan
Copy link
Contributor Author

@ericsnowcurrently Care to take a quick look at this one before I merge it? They're the updates I was working on during the PyCon sprints, but didn't get around to publishing.

@brettcannon brettcannon changed the title PEP 432: Update for C99 initializers WIP: PEP 432: Update for C99 initializers Jun 16, 2016
@brettcannon
Copy link
Member

Tweaked the title to mention this is a WIP so no one accepts this PR by accident while @ncoghlan waits to hear from @ericsnowcurrently .

which, by default, operates in "isolated mode" (as selected by the CPython
``-I`` switch).
``-I`` switch), as well as the creation of an example stub binary that just
runs an appended zip archive (permitting single-file pure Python executables)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I recall, Thomas indicated that there were some problems with this approach which required sticking the archive into the elf data section. It sounded like that was something different than just appending the zip archive.

@brettcannon brettcannon changed the title WIP: PEP 432: Update for C99 initializers [WIP] PEP 432: Update for C99 initializers Jul 1, 2016
@dstufft
Copy link
Member

dstufft commented Jul 5, 2016

Just closing/reopening this so Travis will pick it up.

@brettcannon
Copy link
Member

What's the status of this PR, @ncoghlan ?

@ncoghlan
Copy link
Contributor Author

This still needs the additional explanations mentioned in the discussion between @ericsnowcurrently and myself - merging as is would be a little confusing as to the rationale for some of the revised design decisions.

Addressing that is sitting somewhere on the todo list :)

@brettcannon
Copy link
Member

Should this get closed and moved over to someone's personal fork until it's ready for being merged?

@ncoghlan ncoghlan changed the title [WIP] PEP 432: Update for C99 initializers PEP 432: Update for C99 initializers Sep 21, 2016
@ncoghlan ncoghlan merged commit 3b87611 into python:master Sep 21, 2016
@ncoghlan
Copy link
Contributor Author

The remaining work was a "I need to better explain the rationale for this approach", but there's no need to hold the PR open for that.

@ncoghlan
Copy link
Contributor Author

I moved the TODO aspect over to my sandbox repo: https://bitbucket.org/ncoghlan/cpython_sandbox/issues/3/pep-432-update-to-consistently-use-object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants