PEP 480: Update PEP 480 to account for changes to PEP 458 #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds various updates to account for changes in PEP 458, including: * updating the link to the Python glossary * add definitions of distribution file, target files * clarify ‘target files’ and ‘target metadata’ * Use BLAKE 2 instead of SHA-2 in filenames * transaction process -> upload process This commit also adds a few clarifications about the purpose of this PEP, including adding an overview of the changes needed to implement the PEP. Signed-off-by: marinamoore <mnm678@gmail.com>
trishankatdatadog
suggested changes
Oct 23, 2020
Contributor
trishankatdatadog
left a comment
trishankatdatadog
left a comment
There was a problem hiding this comment.
LGTM except for minor comments
Use the permanent links from theupdateframework.io Signed-off-by: marinamoore <mnm678@gmail.com>
ncoghlan
approved these changes
Oct 25, 2020
| to developer keys, adding a process to register developer keys with PyPI, and a | ||
| change in the upload workflow for developers who take advantage of end-to-end | ||
| signing. All of these changes are described in detail later in this PEP. Package | ||
| managers that wish to take advantage of end-to-end signing do not need to do any |
Contributor
There was a problem hiding this comment.
With this all in one paragraph, it's easy to miss that the last sentence is about clients rather than the backend infrastructure. I'd suggest make it a separate paragraph and emphasising the *not*
Contributor
|
While I did have a minor cosmetic comment on one of the new paragraphs, I went ahead and merged this to improved the consistency of the online version with PEP 458. |
Contributor
|
Ah, Marina did not add her name to the PEP, I forgot to note this, next time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds various updates to account for changes in PEP 458, including:
This commit also adds a few clarifications about the purpose of this PEP, including adding an overview of the changes needed to implement the PEP