PEP 697: Clean up before PSC acceptance #3041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify in the abstract that this does not apply to all types, things like tuple and int are excluded. But could be done in the future. Fix ``basesize`` vs ``basicsize`` field name typos. Remove the Open Issues section and mention that using a PyType_Spec flag instead of a negative basicsize was rejected and offer an explanation why. (ultimately either way would work with similar impact)
CAM-Gerlach
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify in the abstract that this does not apply to all types, things like tuple and int are excluded. But could be done in the future.
Fix
basesizevsbasicsizefield name typos. oops! 😁Remove the Open Issues section and mention that using a
PyType_Specflag instead of a negative basicsize was rejected and offer an explanation why. (ultimately either way would work with similar impact)📚 Documentation preview 📚: https://pep-previews--3041.org.readthedocs.build/