PEP 810: Updates based on feedback #4636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
moar_updates
branch
3 times, most recently
from
b8d28d8 to
97d245b
Compare
pablogsal
force-pushed
the
moar_updates
branch
from
97d245b to
f98c4ef
Compare
pablogsal
force-pushed
the
moar_updates
branch
from
19f2024 to
f7d9848
Compare
|
CC @warsaw |
warsaw
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Thanks for considering my suggestions from the DPO thread! The changes look great and I made just one suggestion.
One other suggestion I made here is to add this to the filter function section:
The filter function is called at the point of execution of the lazy import or lazy from import statement, not at the point of reification. The filter function may be called concurrently.
Co-authored-by: Barry Warsaw <barry@python.org>
Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pep-previews--4636.org.readthedocs.build/