-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Infra: generate an iCalendar file of the release dates #4704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hugovk
wants to merge
2
commits into
python:main
Choose a base branch
from
hugovk:ical
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [run] | ||
| omit = | ||
| release_management/__main__.py | ||
|
|
||
| [report] | ||
| exclude_also = | ||
| if __name__ == .__main__.: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| output-format = "full" | ||
| target-version = "py310" | ||
| fix = true | ||
|
|
||
| [lint] | ||
| ignore = [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import pytest | ||
| from icalendar import Calendar | ||
| from release_management import serialize | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ('test_input', 'expected'), | ||
| [ | ||
| ('3.14.0 alpha 1', 'python-3.14.0alpha1@python.org'), | ||
| ('3.14.0 beta 2', 'python-3.14.0beta2@python.org'), | ||
| ('3.14.0 candidate 3', 'python-3.14.0candidate3@python.org'), | ||
| ('3.14.1', 'python-3.14.1@python.org'), | ||
| ], | ||
| ) | ||
| def test_ical_uid(test_input, expected): | ||
| assert serialize.ical_uid(test_input) == expected | ||
|
|
||
|
|
||
| def test_create_release_ical_returns_valid_icalendar(): | ||
| # Act | ||
| ical_str = serialize.create_release_ical() | ||
|
|
||
| # Assert | ||
| # Non-empty string | ||
| assert isinstance(ical_str, str) | ||
| assert len(ical_str) > 0 | ||
|
|
||
| # Parseable as a valid iCalendar | ||
| cal = Calendar.from_ical(ical_str) | ||
| assert cal is not None | ||
|
|
||
|
|
||
| def test_create_release_ical_has_calendar_metadata(): | ||
| # Act | ||
| ical_str = serialize.create_release_ical() | ||
|
|
||
| # Assert | ||
| cal = Calendar.from_ical(ical_str) | ||
|
|
||
| # Check calendar metadata | ||
| assert cal.get('version') == '2.0' | ||
| assert cal.get('prodid') == '-//Python Software Foundation//Python releases//EN' | ||
| assert cal.get('x-wr-calname') == 'Python releases' | ||
| assert 'peps.python.org' in cal.get('x-wr-caldesc') | ||
|
|
||
|
|
||
| def test_create_release_ical_first_event(): | ||
| # Act | ||
| ical_str = serialize.create_release_ical() | ||
|
|
||
| # Assert | ||
| cal = Calendar.from_ical(ical_str) | ||
| first_event = cal.events[0] | ||
| assert first_event.get('summary') == 'Python 1.6.0 alpha 1' | ||
| assert str(first_event.get('dtstart').dt) == '2000-03-31' | ||
| assert first_event.get('uid') == 'python-1.6.0alpha1@python.org' | ||
| assert first_event.get('url') == 'https://peps.python.org/pep-0160/' | ||
|
|
||
|
|
||
| def test_create_release_ical_sorted_by_date(): | ||
| # Act | ||
| ical_str = serialize.create_release_ical() | ||
|
|
||
| # Assert | ||
| cal = Calendar.from_ical(ical_str) | ||
| dates = [event.get('dtstart').dt for event in cal.events] | ||
| assert dates == sorted(dates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obligatory “supply chain” security question: do we trust
icalendarmaintainers and their operational security?This could be tasty vector for running code on core dev boxes.
cc @sethmlarson
Maybe consider generating “manually”? iCal is a simple, stable text-based format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou I would recommend generating the ICS file manually within the code instead of relying on a library. The format is quite simple, especially for the use-case we need :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've proposed a simpler alternative at #4705 following this suggestion.
A