Job entry give 502 error when using malformed ReST

[malemburg]

If a user enters wrong ReST into a description field, the record is not saved in the database and the site returns a 502 error.

The jobs app should return to the edit page and report the error instead.

[berkerpeksag]

Do you have any example data to reproduce the issue? I've tried

:ref:``

`foo``

:meth:`foo`

.. versionadded:: 3.5

etc, but didn't get 502 or traceback.

It only prints error messages like

System Message: ERROR/3 (<string>, line 8)

Unknown directive type "versionadded".

[malemburg]

On 17.03.2015 21:20, Berker Peksag wrote:

Do you have any example data to reproduce the issue?

This came up when trying to correct some formatting in a
submission.

Here's an example:

Bad ReST

* **abc*
* *abc**
* **abc**

If you add this to the job description, you can trigger the 502
on the staging system:

https://staging.python.org/jobs/168/edit/

Marc-Andre Lemburg

[berkerpeksag]

Wow, that's weird. With prod settings on my machine, I couldn't get 502. I think we really need to fix python/psf-salt#39 to investigate such issues.

[malemburg]

On 17.03.2015 21:35, Berker Peksag wrote:

Wow, that's weird. With prod settings on my machine, I couldn't get 502. I think we really need to fix python/psf-salt#39 to investigate such issues.

Indeed. Having access to the tracebacks would be really useful :-)

Marc-Andre Lemburg

[malemburg]

Here's the stacktrace from sentry:

ConnectionRefusedError: [Errno 111] Connection refused

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/generic/base.py", line 87, in dispatch
    return handler(request, *args, **kwargs)
  File "django/views/generic/edit.py", line 230, in post
    return super(BaseUpdateView, self).post(request, *args, **kwargs)
  File "django/views/generic/edit.py", line 173, in post
    return self.form_valid(form)
  File "jobs/views.py", line 265, in form_valid
    form = super().form_valid(form)
  File "jobs/views.py", line 216, in form_valid
    self.object = form.save()
  File "cms/forms.py", line 22, in save
    obj.save()
  File "jobs/models.py", line 169, in save
    return super().save(**kwargs)
  File "cms/models.py", line 35, in save
    return super().save(**kwargs)
  File "django/db/models/base.py", line 589, in save
    force_update=force_update, update_fields=update_fields)
  File "django/db/models/base.py", line 617, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "django/db/models/base.py", line 676, in _save_table
    for f in non_pks]
  File "django/db/models/base.py", line 676, in <listcomp>
    for f in non_pks]
  File "markupfield/fields.py", line 143, in pre_save
    rendered = self.markup_choices_dict[value.markup_type](raw)
  File "markupfield/markup.py", line 74, in render_rest
    settings_overrides=overrides)
  File "docutils/core.py", line 448, in publish_parts
    enable_exit_status=enable_exit_status)
  File "docutils/core.py", line 662, in publish_programmatically
    output = pub.publish(enable_exit_status=enable_exit_status)
  File "docutils/core.py", line 217, in publish
    self.settings)
  File "docutils/readers/__init__.py", line 72, in read
    self.parse()
  File "docutils/readers/__init__.py", line 78, in parse
    self.parser.parse(self.input, document)
  File "docutils/parsers/rst/__init__.py", line 172, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "docutils/parsers/rst/states.py", line 170, in run
    input_source=document['source'])
  File "docutils/statemachine.py", line 239, in run
    context, state, transitions)
  File "docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "docutils/parsers/rst/states.py", line 1135, in indent
    elements = self.block_quote(indented, line_offset)
  File "docutils/parsers/rst/states.py", line 1150, in block_quote
    self.nested_parse(blockquote_lines, line_offset, blockquote)
  File "docutils/parsers/rst/states.py", line 282, in nested_parse
    node=node, match_titles=match_titles)
  File "docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "docutils/statemachine.py", line 239, in run
    context, state, transitions)
  File "docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "docutils/parsers/rst/states.py", line 1235, in bullet
    i, blank_finish = self.list_item(match.end())
  File "docutils/parsers/rst/states.py", line 1258, in list_item
    node=listitem)
  File "docutils/parsers/rst/states.py", line 282, in nested_parse
    node=node, match_titles=match_titles)
  File "docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "docutils/statemachine.py", line 245, in run
    result = state.eof(context)
  File "docutils/parsers/rst/states.py", line 2669, in eof
    self.blank(None, context, None)
  File "docutils/parsers/rst/states.py", line 2661, in blank
    context, self.state_machine.abs_line_number() - 1)
  File "docutils/parsers/rst/states.py", line 418, in paragraph
    textnodes, messages = self.inline_text(text, lineno)
  File "docutils/parsers/rst/states.py", line 427, in inline_text
    return self.inliner.parse(text, lineno, self.memo, self.parent)
  File "docutils/parsers/rst/states.py", line 513, in parse
    lineno)
  File "docutils/parsers/rst/states.py", line 731, in strong
    match, lineno, self.patterns.strong, nodes.strong)
  File "docutils/parsers/rst/states.py", line 711, in inline_obj
    % nodeclass.__name__, line=lineno)
  File "docutils/utils/__init__.py", line 220, in warning
    return self.system_message(self.WARNING_LEVEL, *args, **kwargs)
  File "docutils/utils/__init__.py", line 191, in system_message
    self.stream.write(msg.astext() + '\n')
  File "docutils/utils/error_reporting.py", line 189, in write
    self.stream.write(data)

It looks like some error reporting stream is not correctly set up.

[malemburg]

@berkerpeksag: Let me know if you want to get those sentry messages as well. We have an account set up for this now.

[berkerpeksag]

@malemburg that would be great. My email is berker.peksag gmail. Let me know if you need more information from me.

[berkerpeksag]

ConnectionRefusedError looks weird. Did you try to get the same exception several times? It could be a transient failure.

[malemburg]

On 18.03.2015 00:08, Berker Peksag wrote:

ConnectionRefusedError looks weird. Did you try to get the same exception several times? It could be a transient failure.

Yes. It's consistently repeatable.

PS: You have received an invite for sentry now.

Marc-Andre Lemburg

[mjpieters]

This also affects reviewing; e.g. I wasn't able to reject https://www.python.org/jobs/189/ until I fixed a reST error in the job description field.

[berkerpeksag]

https://github.com/python/pythondotorg/blob/master/docutils.conf is fixed this issue. Can we close this now?

[malemburg]

Yes. Thanks, Berker.