Fix can't generate pep pages with local pep repo on local #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkerpeksag
reviewed
Apr 9, 2019
There was a problem hiding this comment.
Thank you! Just to clarify, this PR reverts to old Git-based implementation in development mode and python/peps#982 fixes the problem with reST links, right?
| verbose("== Finished") | ||
|
|
||
| def get_artifacts_path(self, stack, verbose): | ||
| if settings.DEBUG and settings.PEP_REPO_PATH: |
There was a problem hiding this comment.
I don't think we should go back to the old method. Downloading and extracting an artifact from S3 sounds like a better idea to me.
I think we can set settings.PEP_ARTIFACT_URL to os.path.join(settings.BASE, 'peps/tests/peps.tar.gz') in settings/local.py. This way contributors wouldn't need to clone python/peps repo if they would like to work on our PEP converter code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That issue is the result of #1389 .