Skip to content

Conversation

mozillazg
Copy link
Contributor

I think we can set settings.PEP_ARTIFACT_URL to os.path.join(settings.BASE, 'peps/tests/peps.tar.gz') in settings/local.py. This way contributors wouldn't need to clone python/peps repo if they would like to work on our PEP converter code.
---- @berkerpeksag #1412 (comment)

@berkerpeksag What do you think about this PR? Is it necessary?

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the following line:

# Set the URL to where to fetch PEP artifacts from
PEP_ARTIFACT_URL = 'https://pythondotorg-assets-staging.s3.amazonaws.com/fake-peps.tar.gz'

to

PEP_ARTIFACT_URL = os.path.join(BASE, 'peps/tests/peps.tar.gz')

@berkerpeksag berkerpeksag marked this pull request as ready for review April 20, 2019 15:29
berkerpeksag and others added 6 commits April 21, 2019 11:34
@berkerpeksag berkerpeksag merged commit f17ceb8 into python:master Apr 21, 2019
@berkerpeksag
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants