Port decimal stub to Python 2#95
Merged
gvanrossum merged 4 commits intopython:masterfrom Feb 26, 2016
youtux:feature/decimal-2.7
Merged
Port decimal stub to Python 2#95gvanrossum merged 4 commits intopython:masterfrom youtux:feature/decimal-2.7
gvanrossum merged 4 commits intopython:masterfrom
youtux:feature/decimal-2.7
Conversation
Member
|
I apologize for the advice I gave earlier. I think it's better to have separate decimal.pyi files for 2.7 and 3 after all. The number of sections with version-specific comments in this version scares me. |
Contributor
Author
|
Yeah, the single-file strategy would make sense if mypy supported version-specific comments, but until that moment it's better to split. |
gvanrossum
added a commit
that referenced
this pull request
Feb 26, 2016
Port decimal stub to Python 2
Member
|
I'm really sorry, I had to roll this back because there were some deficiencies. For example:
|
Contributor
Author
|
I'll try to fix it as soon as I can. Thank you for pointing that out. |
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2/3 specific code has been commented and TODOs were added, according to #94 (comment).