Rework redis/asyncio/{connection,sentinel}.pyi #10370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
I have no time to look into the pytype error at the moment. @rchen152: Could have a look? Otherwise I'll try to narrow the problem down tomorrow. |
This fixes the pytype tests.
Collaborator
Author
|
The pytype fix was fairly straightforward: Remove the quotes around bound types from the TypeVar, which is cleaner anyway: |
Collaborator
Author
|
(Test failure is a GitHub hickup, I will restart the failed test.) |
This comment has been minimized.
This comment has been minimized.
Member
|
Sorry this PR has been sitting here for so long. There is a fairly big merge conflict; if you fix that I'll review it. |
Member
|
@srittau ping on this one. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10362