improve type annotations in 'docutils.parsers.rst.directives.misc' #11524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Contributor
Author
|
pyright doesn't like the untyped base class |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Member
If a subclass can override them to any value of type |
danieleades
force-pushed
the
docutils.parsers.rst.directives.misc
branch
2 times, most recently
from
07f03b1 to
9c98b26
Compare
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.parsers.rst.directives.misc
branch
from
9c98b26 to
9835a17
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.parsers.rst.directives.misc
branch
from
8da240e to
e27686d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.parsers.rst.directives.misc
branch
from
86a8866 to
f8fd824
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JelleZijlstra i wasn't sure the best way to annotate the class variables in this one, since they are literal values (not changed at runtime) but can in principle be overridden by subclasses. What's the usual approach?