Restore os.path methods overload workaround #12837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Collaborator
There was a problem hiding this comment.
Nice, thanks, and tests looks great! Let's remove the references to python/mypy#3644 since that issue is fixed and replace them with reference to python/mypy#17952 which we can use to track the remaining issue with Any.
(We could also link the issue in re, as Alex mentions here #12208 (review) )
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
I think I did what you meant here. But I'm not certain. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: setuptools (https://github.com/pypa/setuptools)
- pkg_resources/__init__.py:2651: error: Value of type variable "AnyStr" of "abspath" cannot be "Sequence[object]" [type-var]
|
srittau
approved these changes
Oct 17, 2024
hauntsaninja
approved these changes
Oct 17, 2024
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Nice, thank you! Hopefully these get fixed and we can reland the cleanup :-)
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/mypy#17952 and https://github.com/pypa/setuptools/pull/4688/files#diff-e3d3d454fa3a072c9f46f8affa27513892fbc2d245e87f57a5927a7be851de05R2651
Reverts #12208 and adds tests
CC @hauntsaninja @srittau