-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix the length of platform.uname_result #13068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dad5349
fix the length of platform.uname_result
tungol 934266a
ignore
tungol ca05fd0
pyright
tungol ef411cd
add test case and comments
tungol 9a5deac
try a different strategy
tungol da8d551
fixes?
tungol 9c3479b
_fields for 3.9
tungol b16ee65
tweak again
tungol 836c50a
don't try to make processor a property
tungol 4c2ed2d
base order
tungol 9bc9257
don't bother with _uname_result_base
tungol d850b0b
flatten and update comments
tungol dea21c6
bring back _uname_result_base
tungol f53f85d
pyright
tungol 3f79f40
move the comment
tungol 63a6d1a
add reference ticket
tungol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import platform | ||
| import sys | ||
| from typing_extensions import assert_type | ||
|
|
||
| # platform.uname_result emulates a 6 field named tuple, but on 3.9+ the processor | ||
| # field is lazily evaluated, which results in it being a little funky. | ||
| uname = platform.uname() | ||
| if sys.version_info >= (3, 9): | ||
| myuname = platform.uname_result("Darwin", "local", "22.5.0", "Darwin Kernel Version 22.5.0", "arm64") | ||
| else: | ||
| myuname = platform.uname_result("Darwin", "local", "22.5.0", "Darwin Kernel Version 22.5.0", "arm64", "arm") | ||
|
|
||
| assert_type(uname, platform.uname_result) | ||
| assert_type(myuname, platform.uname_result) | ||
|
|
||
| assert_type(uname[5], str) | ||
| assert_type(myuname[5], str) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.