a few more allowlist entries moved to don't fix #13236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
optparse.Values is another class with arbitrary attributes at runtime, so that's don't fix. |
Contributor
Author
|
tkinter.Misc.after was deliberately changed away from matching the runtime last year, and nothing is likely to change there. Reference: #11013 |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.HTTPStatus: https://github.com/python/cpython/blob/ba2d2fda93a03a91ac6cdff319fd23ef51848d51/Lib/http/__init__.py#L26
cached_property.__set__is needed specifically for pyright; I don't see any way around it.I played around a little with
Neveras a return type for an overload ofhmac.new. It works, and it's accurate, but mypy doesn't raise an error on that specifically. You're likely to get related errors when you try to use the result, but they'll be less clear about what's going on than the current errors. I think it's too much of a worse experience to go for.