Skip to content

[configparser] Fix missing fallback argument in SectionProxy.get #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

[configparser] Fix missing fallback argument in SectionProxy.get #13559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7464e10
[configparser] Fix missing fallback argument in SectionProxy.get
srittau Feb 28, 2025
5770c2c
Document Any while we're here
srittau Feb 28, 2025
235a44b
Try to make pyright happy
srittau Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stdlib/@tests/test_cases/check_configparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from configparser import RawConfigParser, SectionProxy
from typing_extensions import assert_type

sp = SectionProxy(RawConfigParser(), "")
assert_type(sp.get("foo", fallback="hi"), str)
11 changes: 9 additions & 2 deletions stdlib/configparser.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,14 @@ class SectionProxy(MutableMapping[str, str]):
# This is incompatible with MutableMapping so we ignore the type
@overload # type: ignore[override]
def get(
self, option: str, *, raw: bool = False, vars: _Section | None = None, _impl: Any | None = None, **kwargs: Any
self,
option: str,
fallback: None = None,
*,
raw: bool = False,
vars: _Section | None = None,
_impl: Any | None = None,
**kwargs: Any, # passed to the underlying parser's get() method
) -> str | None: ...
@overload
def get(
Expand All @@ -331,7 +338,7 @@ class SectionProxy(MutableMapping[str, str]):
raw: bool = False,
vars: _Section | None = None,
_impl: Any | None = None,
**kwargs: Any,
**kwargs: Any, # passed to the underlying parser's get() method
) -> str | _T: ...
# These are partially-applied version of the methods with the same names in
# RawConfigParser; the stubs should be kept updated together
Expand Down