Amend annotation for asyncio.Protocol.__slots__
#14980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assignablity issue in subclasses that was caused by using too strict an annotation for the purpose of
__slots__as a special case for mypy.We can keep an annotation here for mypy if really needed, but it needs to work with subclass assignability.
ideally, long term all data model names are understood as part of the specification, but this needs to be permissive enough to allow subclasses to add members.
See error in pyright as a result of adding a special case for mypy: microsoft/pyright#11058