Add unicode support to py2 string.Template. #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I played around with this in a 2.7 interpreter, and as far as I can tell, the template and mapping keys can be str or unicode, the return type is str if all of the mapping values are str, and the return type is unicode if at least one mappng value is unicode.
srittau
approved these changes
Mar 16, 2019
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thank you. One optional change, since you are currently editing this: Template is actually an old-style class, so it shouldn't derive from object.
Collaborator
Author
|
Fixed! |
Contributor
|
This seems to break substitutions using just a |
Member
|
Makes sense. We should probably use |
rchen152
added a commit
that referenced
this pull request
Mar 27, 2019
Collaborator
Author
|
Sorry about that! I sent #2888 to fix the type of |
rchen152
added a commit
that referenced
this pull request
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around with this in a 2.7 interpreter, and as far as I
can tell, the template and mapping keys can be str or
unicode, the return type is str if all of the mapping values are
str, and the return type is unicode if at least one mapping value
is unicode.