Set a default value for output in CalledProcessError.__init__ #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmaeklavya2
added a commit
to sharmaeklavya2/zulip
that referenced
this pull request
Jul 2, 2016
Subprocess.CalledProcessError's __init__ takes 4 arguments out of which 2 are optional. It is being passed 2 arguments in zulip_tools.py. However, the python 3 stubs are incorrect and they have marked 1 argument as default (see python/typeshed#329). Add a '# type: ignore' to that line so that mypy check passes in python 3 mode.
sharmaeklavya2
added a commit
to sharmaeklavya2/zulip
that referenced
this pull request
Jul 2, 2016
Subprocess.CalledProcessError's __init__ takes 4 arguments out of which 2 are optional. It is being passed 2 arguments in zulip_tools.py. However, python 3 stubs are incorrect and only 1 argument has been marked as default. See python/typeshed#329. Add '# type: ignore' to that line so that mypy check passes in python 3 mode.
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Jul 2, 2016
Subprocess.CalledProcessError's __init__ takes 4 arguments out of which 2 are optional. It is being passed 2 arguments in zulip_tools.py. However, python 3 stubs are incorrect and only 1 argument has been marked as default. See python/typeshed#329. Add '# type: ignore' to that line so that mypy check passes in python 3 mode.
TomaszKolek
pushed a commit
to TomaszKolek/zulip
that referenced
this pull request
Jul 6, 2016
Subprocess.CalledProcessError's __init__ takes 4 arguments out of which 2 are optional. It is being passed 2 arguments in zulip_tools.py. However, python 3 stubs are incorrect and only 1 argument has been marked as default. See python/typeshed#329. Add '# type: ignore' to that line so that mypy check passes in python 3 mode.
TomaszKolek
pushed a commit
to TomaszKolek/zulip
that referenced
this pull request
Aug 25, 2016
Subprocess.CalledProcessError's __init__ takes 4 arguments out of which 2 are optional. It is being passed 2 arguments in zulip_tools.py. However, python 3 stubs are incorrect and only 1 argument has been marked as default. See python/typeshed#329. Add '# type: ignore' to that line so that mypy check passes in python 3 mode.
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError says that
CalledProcessError'soutputisNoneif not specified.I checked the source code of subprocess.py and there
CalledProcessError's__init__took a default value ofNonefor the parameteroutput.