Remove queue #3879
Merged
Remove queue #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JelleZijlstra Can you review and merge this? |
rchen152
added a commit
that referenced
this pull request
May 17, 2020
This attribute was removed in #3879 because it is undocumented and was annotated incorrectly. Unfortunately, a surprising (?) amount of Google code uses this attribute and assumes it is a deque, so it needs to exist but can't have a more general annotation like Collection[Any]. I also removed a no-longer-used typing.Deque import.
JelleZijlstra
pushed a commit
that referenced
this pull request
May 18, 2020
This attribute was removed in #3879 because it is undocumented and was annotated incorrectly. Unfortunately, a surprising (?) amount of Google code uses this attribute and assumes it is a deque, so it needs to exist but can't have a more general annotation like Collection[Any]. I also removed a no-longer-used typing.Deque import.
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
) This attribute was removed in python#3879 because it is undocumented and was annotated incorrectly. Unfortunately, a surprising (?) amount of Google code uses this attribute and assumes it is a deque, so it needs to exist but can't have a more general annotation like Collection[Any]. I also removed a no-longer-used typing.Deque import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3472