Skip to content

Only run mypy primer workflows on stdlib #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 1 commit into from
May 11, 2021
Merged

Only run mypy primer workflows on stdlib #5407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/mypy_primer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Run mypy_primer
on:
# Only run on PR, since we diff against master
pull_request:
# Since modular typeshed, mypy primer doesn't check third party stubs. Till that is changed,
# only run it on stdlib changes to avoid false confidence and wasted CI minutes.
paths:
- stdlib

permissions:
contents: read
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/mypy_primer_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
# each other, so the approach here is to poll for workflow runs, find the mypy_primer run for our
# commit, wait till it's completed, and download and post the diff.
pull_request_target:
# Since modular typeshed, mypy primer doesn't check third party stubs. Till that is changed,
# only run it on stdlib changes to avoid false confidence and wasted CI minutes.
paths:
- stdlib

permissions:
contents: read
Expand Down