Move pickle stubs to protocols #6101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
PeterJCLaw
force-pushed
the
fix-5477-pickle-io-protocols
branch
from
abcb979 to
d0f3ec8
Compare
This is based on the same approach used for things like gzip and tarfile, with the members needed determined by inspection of the pure-Python implementation of pickle within the cpython repo. Fixes python#5477
PeterJCLaw
force-pushed
the
fix-5477-pickle-io-protocols
branch
from
d0f3ec8 to
09020c1
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the same approach used for things like
gzipandtarfile, with the members needed determined by inspection of the pure-Python implementation of pickle within the cpython repo (i.e: https://github.com/python/cpython/blob/main/Lib/pickle.py).Fixes #5477