Fix installing dependencies for 3rd party stubtest #8807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubtest Also fix tests.yml
This reverts commit d4ca397.
srittau
approved these changes
Sep 29, 2022
Collaborator
Author
|
CI passed with a temporary commit that changed a third-party stub. |
This reverts commit 74baebc.
AlexWaygood
approved these changes
Sep 29, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8805
I believe it's fine to just install all dependencies, because stubtest uses venvs that don't "inherit" the dependencies installed here. If this isn't correct, we can grep the dependencies we actually need (I actually implemented and reverted this already).