Skip to content

Raise TypeError when TypeAliasType is subscripted without having type_params #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 26, 2024
Merged

Raise TypeError when TypeAliasType is subscripted without having type_params #473

merged 7 commits into from
Sep 26, 2024

Conversation

@Daraan
Copy link
Contributor

@Daraan Daraan commented Sep 26, 2024

I was not sure if it should check against __parameters__ or __type_params__ the source checks against the later.

@Daraan Daraan mentioned this pull request Sep 26, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 2c84de1 into python:main Sep 26, 2024
21 checks passed
@Daraan Daraan deleted the typealiastype/subscription_checks branch September 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeAliasType not raising TypeError when it is has no parameters

3 participants

@Daraan @JelleZijlstra @AlexWaygood