Skip to content

Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2018
Merged

Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE #169

merged 4 commits into from
Aug 28, 2018

Conversation

@Helow19274
Copy link
Contributor

@Helow19274 Helow19274 commented Aug 20, 2018

No description provided.

python273
python273 reviewed Aug 20, 2018
View reviewed changes
vk_api/longpoll.py
self.type = VkChatEventType(self.type_id)

elif self.type is VkEventType.NOTIFICATION_SETTINGS_UPDATE:
self._dict_to_attr(self.values)
Copy link
Owner

@python273 python273 Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А оно там задокументировано?

Copy link
Contributor Author

@Helow19274 Helow19274 Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По документации формат такой же, как в остальных событиях

Copy link
Owner

@python273 python273 Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может написать в ТП и спросить? Возможно это баг на их стороне или нужно документацию обновить

Copy link
Contributor Author

@Helow19274 Helow19274 Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок, напишу

Copy link
Contributor Author

@Helow19274 Helow19274 Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Среднее время ожидания 62 часа

Copy link
Contributor Author

@Helow19274 Helow19274 Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ответ поддержки заключался в том, чтобы поставить mode=10.
Мой ответ им:

  1. mode=10 не задокументирован.
  2. Попробовал, ничего не изменилось.

Copy link
Contributor Author

@Helow19274 Helow19274 Aug 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В итоге он сказал что так быть и должно

python273
python273 reviewed Aug 27, 2018
View reviewed changes
vk_api/longpoll.py Outdated

def _dict_to_attr(self, values):
for i in values.keys():
self.__setattr__(i, values[i])
Copy link
Owner

@python273 python273 Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут можно iteritems (нужно через six)

@Helow19274
Copy link
Contributor Author

Helow19274 commented Aug 27, 2018

Было бы хорошо перейти на 3 версию, но там немного другой формат данных. Поэтому откатил

@python273
Copy link
Owner

python273 commented Aug 27, 2018

Было бы хорошо перейти на 3 версию, но там немного другой формат данных. Поэтому откатил

Ну если там только в вложениях разница, то наверное можно обновить

@Helow19274
Copy link
Contributor Author

Helow19274 commented Aug 27, 2018 •
edited
Loading

Версия 1
default

Версия 3
default

Это новое сообщение
А так как формат другой, сразу вылетает

@python273 python273 merged commit 9fd2c69 into python273:master Aug 28, 2018
SlavikMIPT added a commit to SlavikMIPT/vk_api that referenced this pull request Sep 25, 2018
@SlavikMIPT
API 5.85 (#1)
8e94ab9 
* Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE (python273#169)

* Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE

* New Bot Longpoll event

* Bump api version

* Bot longpoll example (python273#173)

* 11 event

* Add Travis CI PyPI uploading

* Update version to 11.1.0

* Version 5.85, lp version 3, setup.py open encoding (python273#181)

* Version 5.85, lp version 3
SlavikMIPT added a commit to SlavikMIPT/vk_api that referenced this pull request Sep 25, 2018
@SlavikMIPT
Squashed commit of the following:
774f62b 
commit 0477dd1cae9ca9600ea08991099ea2471bd8517e
Merge: 2028653 a495b86
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 17:55:15 2018 +0300

    Merge branch 'master' of https://github.com/SlavikMIPT/vk_api

commit 2028653cd072c0064da77e7c887b77b39a039ad8
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 17:54:43 2018 +0300

    Squashed commit of the following:

    commit a495b86
    Merge: b114f00 afa5f5d
    Author: slavikmipt <slavikmipt@gmail.com>
    Date:   Tue Sep 25 12:35:10 2018 +0300

        Merge branch 'master' of https://github.com/SlavikMIPT/vk_api

    commit b114f00
    Author: slavikmipt <slavikmipt@gmail.com>
    Date:   Tue Sep 25 12:34:45 2018 +0300

        server_auth

    commit afa5f5d
    Merge: 922978c e0c54b1
    Author: SlavikMIPT <slavikmipt@gmail.com>
    Date:   Tue Sep 25 12:25:40 2018 +0300

        Merge branch 'master' into master

    commit 922978c
    Author: slavikmipt <slavikmipt@gmail.com>
    Date:   Tue Sep 25 12:20:07 2018 +0300

        example refactored

    commit f3df6d8
    Author: slavikmipt <slavikmipt@gmail.com>
    Date:   Tue Sep 25 12:15:35 2018 +0300

        Поддержка прокси для загрузки VHQ audio

    commit 8e94ab9
    Author: SlavikMIPT <slavikmipt@gmail.com>
    Date:   Tue Sep 25 11:34:54 2018 +0300

        API 5.85 (#1)

        * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE (python273#169)

        * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE

        * New Bot Longpoll event

        * Bump api version

        * Bot longpoll example (python273#173)

        * 11 event

        * Add Travis CI PyPI uploading

        * Update version to 11.1.0

        * Version 5.85, lp version 3, setup.py open encoding (python273#181)

        * Version 5.85, lp version 3

    commit e0c54b1
    Author: Igor <helow@helow19274.tk>
    Date:   Mon Sep 24 15:13:39 2018 +0300

        Version 5.85, lp version 3, setup.py open encoding (python273#181)

        * Version 5.85, lp version 3

    commit 3f1e7df
    Author: python273 <iam@python273.pw>
    Date:   Mon Sep 17 22:31:00 2018 +0300

        Update version to 11.1.0

    commit 8e4bae7
    Author: python273 <iam@python273.pw>
    Date:   Mon Sep 17 22:22:57 2018 +0300

        Add Travis CI PyPI uploading

    commit db136aa
    Author: Igor <helow@helow19274.tk>
    Date:   Thu Sep 6 18:11:16 2018 +0300

        11 event

    commit a6884e6
    Author: Igor <helow@helow19274.tk>
    Date:   Thu Sep 6 05:11:23 2018 +0300

        Bot longpoll example (python273#173)

    commit b598bd3
    Author: Igor <helow@helow19274.tk>
    Date:   Wed Aug 29 20:51:31 2018 +0300

        Bump api version

    commit 55f69fe
    Author: Igor <helow@helow19274.tk>
    Date:   Wed Aug 29 20:51:03 2018 +0300

        New Bot Longpoll event

    commit 9fd2c69
    Author: Igor <helow@helow19274.tk>
    Date:   Tue Aug 28 13:15:27 2018 +0300

        Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE (python273#169)

        * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE
    Revert "lambda -> regexp"

    This reverts commit 13953fd.

commit a495b86
Merge: b114f00 afa5f5d
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 12:35:10 2018 +0300

    Merge branch 'master' of https://github.com/SlavikMIPT/vk_api

commit b114f00
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 12:34:45 2018 +0300

    server_auth

commit afa5f5d
Merge: 922978c e0c54b1
Author: SlavikMIPT <slavikmipt@gmail.com>
Date:   Tue Sep 25 12:25:40 2018 +0300

    Merge branch 'master' into master

commit 922978c
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 12:20:07 2018 +0300

    example refactored

commit f3df6d8
Author: slavikmipt <slavikmipt@gmail.com>
Date:   Tue Sep 25 12:15:35 2018 +0300

    Поддержка прокси для загрузки VHQ audio

commit 8e94ab9
Author: SlavikMIPT <slavikmipt@gmail.com>
Date:   Tue Sep 25 11:34:54 2018 +0300

    API 5.85 (#1)

    * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE (python273#169)

    * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE

    * New Bot Longpoll event

    * Bump api version

    * Bot longpoll example (python273#173)

    * 11 event

    * Add Travis CI PyPI uploading

    * Update version to 11.1.0

    * Version 5.85, lp version 3, setup.py open encoding (python273#181)

    * Version 5.85, lp version 3

commit e0c54b1
Author: Igor <helow@helow19274.tk>
Date:   Mon Sep 24 15:13:39 2018 +0300

    Version 5.85, lp version 3, setup.py open encoding (python273#181)

    * Version 5.85, lp version 3

commit 3f1e7df
Author: python273 <iam@python273.pw>
Date:   Mon Sep 17 22:31:00 2018 +0300

    Update version to 11.1.0

commit 8e4bae7
Author: python273 <iam@python273.pw>
Date:   Mon Sep 17 22:22:57 2018 +0300

    Add Travis CI PyPI uploading

commit db136aa
Author: Igor <helow@helow19274.tk>
Date:   Thu Sep 6 18:11:16 2018 +0300

    11 event

commit a6884e6
Author: Igor <helow@helow19274.tk>
Date:   Thu Sep 6 05:11:23 2018 +0300

    Bot longpoll example (python273#173)

commit b598bd3
Author: Igor <helow@helow19274.tk>
Date:   Wed Aug 29 20:51:31 2018 +0300

    Bump api version

commit 55f69fe
Author: Igor <helow@helow19274.tk>
Date:   Wed Aug 29 20:51:03 2018 +0300

    New Bot Longpoll event

commit 9fd2c69
Author: Igor <helow@helow19274.tk>
Date:   Tue Aug 28 13:15:27 2018 +0300

    Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE (python273#169)

    * Add chat event 4, fix NOTIFICATION_SETTINGS_UPDATE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@python273 python273 python273 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Helow19274 @python273