Skip to content

Conversation

r41k0u
Copy link
Collaborator

@r41k0u r41k0u commented Sep 29, 2025

No description provided.

@r41k0u r41k0u marked this pull request as ready for review September 29, 2025 20:16
@r41k0u r41k0u requested a review from Copilot September 29, 2025 20:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the struct handling code by moving it into a dedicated structs module and improving the code organization. The refactor introduces a new StructType class to encapsulate struct-related functionality and replaces the previous dictionary-based approach with object-oriented design.

  • Moved struct processing code from structs_pass.py to structs/structs_pass.py
  • Created new StructType class to replace dictionary-based struct representation
  • Updated all references throughout the codebase to use the new StructType interface

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pythonbpf/structs_pass.py Deleted - moved to structs/ subdirectory
pythonbpf/structs/structs_pass.py New modular struct processing with improved error handling and logging
pythonbpf/structs/struct_type.py New StructType class encapsulating struct operations
pythonbpf/functions_pass.py Updated to use new StructType interface
pythonbpf/expr_pass.py Updated to use new StructType interface
pythonbpf/codegen.py Updated import path for struct processing
pythonbpf/bpf_helper_handler.py Updated to use new StructType interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@r41k0u r41k0u merged commit 1adf7d7 into master Sep 29, 2025
@varun-r-mallya varun-r-mallya deleted the struct_refactor branch October 1, 2025 20:27
@varun-r-mallya varun-r-mallya moved this to In progress in TODOs Oct 8, 2025
@varun-r-mallya varun-r-mallya moved this from In progress to Done in TODOs Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant