Fix segfault regression in 2021.7.0 #209

itamarst · 2021-07-17T22:27:50Z

Fixes #208

Run tests on wheel, to catch future regressions (3.8 only for now, but at least it's catching current regression)
Actually fix the segfault

github-actions · 2021-07-17T22:34:21Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..1a860a8 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3686363,+}
    "D1mw": [-2713965,-]{+2789404,+}
    "DLmr": [-1452624,-]{+1537560,+}
    "DLmw": [-1779154,-]{+1860149,+}
    "Dr": [-229508709,-]{+230379017,+}
    "Dw": [-93311599,-]{+92901690,+}
    "I1mr": [-4106758,-]{+3403403,+}
    "ILmr": [-14565,-]{+15765,+}
    "Ir": [-866790745,-]{+879704991,+}
    "Overall": [-1328904831-]{+1344906598+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..7effc43 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1856207,+}
    "D1mw": [-386474,-]{+396370,+}
    "DLmr": [-60435,-]{+57391,+}
    "DLmw": [-78194,-]{+77728,+}
    "Dr": [-77751713,-]{+73475505,+}
    "Dw": [-32292276,-]{+30221882,+}
    "I1mr": [-1495362,-]{+1613343,+}
    "ILmr": [-8373,-]{+8971,+}
    "Ir": [-257981761,-]{+244190634,+}
    "Overall": [-387246590-]{+367674401+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..0e8a271 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6567571,+}
    "D1mw": [-1170982,-]{+1760600,+}
    "DLmr": [-27810,-]{+32282,+}
    "DLmw": [-55475,-]{+66713,+}
    "Dr": [-360208809,-]{+368209027,+}
    "Dw": [-152234419,-]{+154090949,+}
    "I1mr": [-8048210,-]{+9456207,+}
    "ILmr": [-8271,-]{+8867,+}
    "Ir": [-1136235757,-]{+1174609764,+}
    "Overall": [-1702276157-]{+1771283112+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..ad14de2 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev2+gc4a763f.d20210717+}

github-actions · 2021-07-17T22:57:24Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..4a7823e 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3685312,+}
    "D1mw": [-2713965,-]{+2789530,+}
    "DLmr": [-1452624,-]{+1563938,+}
    "DLmw": [-1779154,-]{+1860768,+}
    "Dr": [-229508709,-]{+230377499,+}
    "Dw": [-93311599,-]{+92900693,+}
    "I1mr": [-4106758,-]{+3402232,+}
    "ILmr": [-14565,-]{+15835,+}
    "Ir": [-866790745,-]{+879666629,+}
    "Overall": [-1328904831-]{+1345669347+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..6afc6d2 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1855036,+}
    "D1mw": [-386474,-]{+396857,+}
    "DLmr": [-60435,-]{+57237,+}
    "DLmw": [-78194,-]{+77862,+}
    "Dr": [-77751713,-]{+73474831,+}
    "Dw": [-32292276,-]{+30221740,+}
    "I1mr": [-1495362,-]{+1613247,+}
    "ILmr": [-8373,-]{+8972,+}
    "Ir": [-257981761,-]{+244189636,+}
    "Overall": [-387246590-]{+367668897+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..1fdafcd 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6379202,+}
    "D1mw": [-1170982,-]{+1636906,+}
    "DLmr": [-27810,-]{+32315,+}
    "DLmw": [-55475,-]{+66812,+}
    "Dr": [-360208809,-]{+368194988,+}
    "Dw": [-152234419,-]{+154092630,+}
    "I1mr": [-8048210,-]{+9418116,+}
    "ILmr": [-8271,-]{+8833,+}
    "Ir": [-1136235757,-]{+1173885884,+}
    "Overall": [-1702276157-]{+1769149198+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..c4c0bd4 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev3+g5362876.d20210717+}

github-actions · 2021-07-17T23:13:05Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..cea69fa 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3686397,+}
    "D1mw": [-2713965,-]{+2789945,+}
    "DLmr": [-1452624,-]{+1562455,+}
    "DLmw": [-1779154,-]{+1860639,+}
    "Dr": [-229508709,-]{+230375732,+}
    "Dw": [-93311599,-]{+92901217,+}
    "I1mr": [-4106758,-]{+3408605,+}
    "ILmr": [-14565,-]{+15819,+}
    "Ir": [-866790745,-]{+879638478,+}
    "Overall": [-1328904831-]{+1345622605+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..065882e 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1854500,+}
    "D1mw": [-386474,-]{+396782,+}
    "DLmr": [-60435,-]{+57226,+}
    "DLmw": [-78194,-]{+77862,+}
    "Dr": [-77751713,-]{+73474024,+}
    "Dw": [-32292276,-]{+30221538,+}
    "I1mr": [-1495362,-]{+1613285,+}
    "ILmr": [-8373,-]{+8955,+}
    "Ir": [-257981761,-]{+244184855,+}
    "Overall": [-387246590-]{+367659975+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..5839ddb 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6379256,+}
    "D1mw": [-1170982,-]{+1636929,+}
    "DLmr": [-27810,-]{+32123,+}
    "DLmw": [-55475,-]{+66891,+}
    "Dr": [-360208809,-]{+368193892,+}
    "Dw": [-152234419,-]{+154092162,+}
    "I1mr": [-8048210,-]{+9418010,+}
    "ILmr": [-8271,-]{+8838,+}
    "Ir": [-1136235757,-]{+1173881193,+}
    "Overall": [-1702276157-]{+1769139587+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..88b35e6 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev5+g910e8fe.d20210717+}

github-actions · 2021-07-17T23:14:17Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..063b62c 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3686755,+}
    "D1mw": [-2713965,-]{+2789291,+}
    "DLmr": [-1452624,-]{+1544865,+}
    "DLmw": [-1779154,-]{+1860326,+}
    "Dr": [-229508709,-]{+230378110,+}
    "Dw": [-93311599,-]{+92900998,+}
    "I1mr": [-4106758,-]{+3402218,+}
    "ILmr": [-14565,-]{+15782,+}
    "Ir": [-866790745,-]{+879705006,+}
    "Overall": [-1328904831-]{+1345126360+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..304b9cd 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1855881,+}
    "D1mw": [-386474,-]{+396357,+}
    "DLmr": [-60435,-]{+57384,+}
    "DLmw": [-78194,-]{+77729,+}
    "Dr": [-77751713,-]{+73474681,+}
    "Dw": [-32292276,-]{+30221513,+}
    "I1mr": [-1495362,-]{+1613233,+}
    "ILmr": [-8373,-]{+8972,+}
    "Ir": [-257981761,-]{+244187714,+}
    "Overall": [-387246590-]{+367668342+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..6d298c0 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6567917,+}
    "D1mw": [-1170982,-]{+1760608,+}
    "DLmr": [-27810,-]{+32288,+}
    "DLmw": [-55475,-]{+66713,+}
    "Dr": [-360208809,-]{+368208453,+}
    "Dw": [-152234419,-]{+154090700,+}
    "I1mr": [-8048210,-]{+9456205,+}
    "ILmr": [-8271,-]{+8868,+}
    "Ir": [-1136235757,-]{+1174607958,+}
    "Overall": [-1702276157-]{+1771282101+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..d8c0487 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev6+g93f2cfd.d20210717+}

github-actions · 2021-07-18T05:07:58Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..a449596 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3685881,+}
    "D1mw": [-2713965,-]{+2790014,+}
    "DLmr": [-1452624,-]{+1560663,+}
    "DLmw": [-1779154,-]{+1860605,+}
    "Dr": [-229508709,-]{+230376944,+}
    "Dw": [-93311599,-]{+92901469,+}
    "I1mr": [-4106758,-]{+3411249,+}
    "ILmr": [-14565,-]{+15888,+}
    "Ir": [-866790745,-]{+879647066,+}
    "Overall": [-1328904831-]{+1345588735+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..411c0e3 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1854422,+}
    "D1mw": [-386474,-]{+396845,+}
    "DLmr": [-60435,-]{+57238,+}
    "DLmw": [-78194,-]{+77862,+}
    "Dr": [-77751713,-]{+73474926,+}
    "Dw": [-32292276,-]{+30221774,+}
    "I1mr": [-1495362,-]{+1613218,+}
    "ILmr": [-8373,-]{+8963,+}
    "Ir": [-257981761,-]{+244188458,+}
    "Overall": [-387246590-]{+367664988+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..3f74c16 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6379152,+}
    "D1mw": [-1170982,-]{+1636944,+}
    "DLmr": [-27810,-]{+32318,+}
    "DLmw": [-55475,-]{+66810,+}
    "Dr": [-360208809,-]{+368194844,+}
    "Dw": [-152234419,-]{+154092597,+}
    "I1mr": [-8048210,-]{+9417982,+}
    "ILmr": [-8271,-]{+8841,+}
    "Ir": [-1136235757,-]{+1173884808,+}
    "Overall": [-1702276157-]{+1769147631+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..6d02132 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev7+g6f77975.d20210718+}

github-actions · 2021-07-18T23:55:58Z

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index a96ee9b..7b5d97a 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3655149,-]{+3686104,+}
    "D1mw": [-2713965,-]{+2789358,+}
    "DLmr": [-1452624,-]{+1537522,+}
    "DLmw": [-1779154,-]{+1860152,+}
    "Dr": [-229508709,-]{+230378001,+}
    "Dw": [-93311599,-]{+92901215,+}
    "I1mr": [-4106758,-]{+3403404,+}
    "ILmr": [-14565,-]{+15768,+}
    "Ir": [-866790745,-]{+879702455,+}
    "Overall": [-1328904831-]{+1344900395+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index e61801c..4a9df80 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-1820859,-]{+1855653,+}
    "D1mw": [-386474,-]{+396368,+}
    "DLmr": [-60435,-]{+57385,+}
    "DLmw": [-78194,-]{+77728,+}
    "Dr": [-77751713,-]{+73474988,+}
    "Dw": [-32292276,-]{+30221595,+}
    "I1mr": [-1495362,-]{+1613357,+}
    "ILmr": [-8373,-]{+8980,+}
    "Ir": [-257981761,-]{+244189749,+}
    "Overall": [-387246590-]{+367670634+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index c0224e2..4da8d05 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-3493431,-]{+6567954,+}
    "D1mw": [-1170982,-]{+1760612,+}
    "DLmr": [-27810,-]{+32287,+}
    "DLmw": [-55475,-]{+66713,+}
    "Dr": [-360208809,-]{+368208365,+}
    "Dw": [-152234419,-]{+154090659,+}
    "I1mr": [-8048210,-]{+9456206,+}
    "ILmr": [-8271,-]{+8868,+}
    "Ir": [-1136235757,-]{+1174607342,+}
    "Overall": [-1702276157-]{+1771281494+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index 30019eb..5179349 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.5.1.dev10+g128d75e.d20210518-]{+2021.7.1.dev8+g6cbc357.d20210718+}

Some minimal testing of wheels after they're built.

12ad5aa

Fix glob.

d8e1a6f

itamarst added 3 commits July 17, 2021 16:04

Explanation of where config comes from.

4a362d4

Install dev dependencies.

593caa3

Install dev dependencies.

1a1946e

Force rebuild of C code across versions.

8d65270

itamarst marked this pull request as ready for review July 18, 2021 05:24

Prepare for release.

b91f6bb

itamarst merged commit 48278c1 into master Jul 19, 2021

itamarst deleted the 208-wheel-segfault branch July 19, 2021 00:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix segfault regression in 2021.7.0 #209

Fix segfault regression in 2021.7.0 #209

Uh oh!

itamarst commented Jul 17, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Jul 17, 2021

Uh oh!

github-actions bot commented Jul 17, 2021

Uh oh!

github-actions bot commented Jul 17, 2021

Uh oh!

github-actions bot commented Jul 17, 2021

Uh oh!

github-actions bot commented Jul 18, 2021

Uh oh!

github-actions bot commented Jul 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix segfault regression in 2021.7.0 #209

Fix segfault regression in 2021.7.0 #209

Uh oh!

Conversation

itamarst commented Jul 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2021

Benchmark results

Uh oh!

github-actions bot commented Jul 17, 2021

Benchmark results

Uh oh!

github-actions bot commented Jul 17, 2021

Benchmark results

Uh oh!

github-actions bot commented Jul 17, 2021

Benchmark results

Uh oh!

github-actions bot commented Jul 18, 2021

Benchmark results

Uh oh!

github-actions bot commented Jul 18, 2021

Benchmark results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

itamarst commented Jul 17, 2021 •

edited

Loading