Skip to content

Conversation

@circld
Copy link

@circld circld commented Feb 28, 2018

Fix a broken example (or at the very least, make it clearer that curried analogs must be used) from the streaming analytics docs.

@eriknw
Copy link
Member

eriknw commented Aug 14, 2018

Cool, it makes sense to be explicit about what functions are curried, and using curried directly is probably good practice. I would write the import as from toolz import curried though. Previously, I think from toolz.curried import * was implied.

Thanks @circld for careful reading and taking the initiative to make this update!

@eriknw
Copy link
Member

eriknw commented Jun 22, 2019

Closing, because I think this was sufficiently covered in #435.

Thanks again @circld for carefully reading the docs and making a PR! (and sorry for my excessive delay)

@eriknw eriknw closed this Jun 22, 2019
@circld
Copy link
Author

circld commented Aug 2, 2019

all good, thanks for the awesome module 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants