Skip to content

Fix DeprecationWarning in Python 3.7 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2018
Merged

Fix DeprecationWarning in Python 3.7 #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01e4313
Fix DeprecationWarning in Python 3.7
hugovk Oct 6, 2018
cb94a5b
Ignore file created when running tests
hugovk Oct 6, 2018
e9cea93
Don't cover non-runnable code on Python 3
hugovk Oct 6, 2018
a055df3
Ignore file created when running tests with coverage
hugovk Oct 6, 2018
1804af0
Move compat code to compatibility.py
hugovk Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
build/
dist/
*.egg-info/
bench/shakespeare.txt
.coverage
2 changes: 2 additions & 0 deletions toolz/compatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
iteritems = operator.methodcaller('items')
iterkeys = operator.methodcaller('keys')
itervalues = operator.methodcaller('values')
from collections.abc import Sequence
else:
range = xrange
reduce = reduce
Expand All @@ -30,3 +31,4 @@
iteritems = operator.methodcaller('iteritems')
iterkeys = operator.methodcaller('iterkeys')
itervalues = operator.methodcaller('itervalues')
from collections import Sequence
4 changes: 2 additions & 2 deletions toolz/itertoolz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from functools import partial
from random import Random
from toolz.compatibility import (map, filterfalse, zip, zip_longest, iteritems,
filter)
filter, Sequence)
from toolz.utils import no_default


Expand Down Expand Up @@ -391,7 +391,7 @@ def nth(n, seq):
>>> nth(1, 'ABC')
'B'
"""
if isinstance(seq, (tuple, list, collections.Sequence)):
if isinstance(seq, (tuple, list, Sequence)):
return seq[n]
else:
return next(itertools.islice(seq, n, None))
Expand Down