Skip to content

Faster itertoolz.update_in #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Faster itertoolz.update_in #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba9d148
Use a non-recursive implementation inspired by cytoolz.
groutr Dec 6, 2018
b2eb929
Fix linting error.
groutr Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions toolz/dicttoolz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,15 +266,28 @@ def update_in(d, keys, func, default=None, factory=dict):
>>> update_in({1: 'foo'}, [2, 3, 4], inc, 0)
{1: 'foo', 2: {3: {4: 1}}}
"""
assert len(keys) > 0
k, ks = keys[0], keys[1:]
if ks:
return assoc(d, k, update_in(d[k] if (k in d) else factory(),
ks, func, default, factory),
factory)
ks = iter(keys)
k = next(ks)

rv = inner = factory()
rv.update(d)

for key in ks:
if k in d:
d = d[k]
dtemp = factory()
dtemp.update(d)
else:
d = dtemp = factory()

inner[k] = inner = dtemp
k = key

if k in d:
inner[k] = func(d[k])
else:
innermost = func(d[k]) if (k in d) else func(default)
return assoc(d, k, innermost, factory)
inner[k] = func(default)
return rv


def get_in(keys, coll, default=None, no_default=False):
Expand Down