refactor parallel.fold #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fold cannot use lambdas if using multiprocessing.Pool().map() chunksize should not be less than 2
Previously I planned to force chunksize value to be larger than 2 and wrote a test to allow chunksize equal to two. Fold takes a combination function which I am not sure how to interpret and prefer not to mess with so if the user choses a chunksize of 1 than we raise an exception instead of trapping ourselves in an infinite loop.
Member
|
LGTM. Thanks @medecau! Sorry for the delay. |
Contributor
Author
|
🙏 Thank you for taking the time to review this. Really happy 😁 to be able to contribute to toolz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request refactors parallel.fold to make it work with multiprocessing.Pool.map()
I ran into a few problems while writing code for this. Lambdas cannot be used and
reduce()cannot be partially applied with keyword arguments.