Skip to content

Conversation

@EricTheMagician
Copy link
Contributor

@EricTheMagician EricTheMagician commented Jan 10, 2019

fix #436
Not sure if there's a cleaner way, but this works.

fix memory leak with objects contained in the exception / traceback.
@eriknw
Copy link
Member

eriknw commented Jan 10, 2019

Thanks! Looks reasonable to me. We may want to look more closely and add a couple tests for when sigspec (as it's called in the code) is passed to other functions while it's None.

@EricTheMagician
Copy link
Contributor Author

@eriknw
Since it's such a simple fix, and that you know the codebase much more than I do, can I leave you to write the tests for these?

From what I had seen, there shouldn't be any issue, but I wouldn't know what to test beyond the existing tests.

@eriknw eriknw merged commit 2a6ef53 into pytoolz:master Jan 21, 2019
@eriknw
Copy link
Member

eriknw commented Jan 21, 2019

LGTM, thanks @thejinx0r and @akhilman! We're past due for a release, so I'll get this up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory leak with curry

3 participants