-
Notifications
You must be signed in to change notification settings - Fork 270
Remove Python 2 support #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also removed 3.7-dev
|
@eriknw this is ready for review. |
|
@eriknw This should be ready now. |
We also check that PYPY is a version that supports Python 3.
These tests are testing features of Python 3. We test that the import works.
Update setup.py to reflect current Python support.
This reverts commit 81aafd6.
|
Added Python 3.9-dev to tested versions. |
|
@eriknw I restored the Python 3 section of compatibility.py and added a deprecation warning. This feels like a pretty cluttered PR (my travis ci config skills are not great), perhaps I should clean up the commits and open a new PR. |
|
I need to confirm, since I think I crossed my wires in my head, should toolz continue to advertise support for Python 3.4 if we don't test against it? |
|
Thanks again for all this @groutr . I'm fine dropping (and not advertising) Python 3.4 since it's already end-of-life. Python 3.5 only has six more months. |
|
Looks great, let's get this in today! |
|
Oh, and |
|
@eriknw Finished removing references to Python 3.4 and fixed the pragma checks. |
|
LGTM. Shall we merge? Thanks again for doing the heavy lifting and being patient and persistent. |
|
I think this is in a merge-able state. There are some more things that I will do in another PR that will build off this.
for item in seq
yield item |
@eriknw, this PR removes Python 2.7 support.