Skip to content

Conversation

@groutr
Copy link
Contributor

@groutr groutr commented Jul 13, 2019

@eriknw, this PR removes Python 2.7 support.

@groutr groutr marked this pull request as ready for review July 15, 2019 23:07
@groutr
Copy link
Contributor Author

groutr commented Jul 22, 2019

@eriknw this is ready for review.

@groutr
Copy link
Contributor Author

groutr commented Oct 17, 2019

@eriknw This should be ready now.

@groutr
Copy link
Contributor Author

groutr commented Mar 16, 2020

Added Python 3.9-dev to tested versions.

@groutr
Copy link
Contributor Author

groutr commented Mar 16, 2020

@eriknw I restored the Python 3 section of compatibility.py and added a deprecation warning. This feels like a pretty cluttered PR (my travis ci config skills are not great), perhaps I should clean up the commits and open a new PR.

@groutr
Copy link
Contributor Author

groutr commented Mar 16, 2020

I need to confirm, since I think I crossed my wires in my head, should toolz continue to advertise support for Python 3.4 if we don't test against it?

@eriknw
Copy link
Member

eriknw commented Mar 16, 2020

Thanks again for all this @groutr . I'm fine dropping (and not advertising) Python 3.4 since it's already end-of-life. Python 3.5 only has six more months.

@eriknw
Copy link
Member

eriknw commented Mar 16, 2020

Looks great, let's get this in today!

@eriknw
Copy link
Member

eriknw commented Mar 16, 2020

Oh, and .coveragerc no longer needs the pragma: py$MAJOR_PYTHON_VERSION no cover trick.

@groutr
Copy link
Contributor Author

groutr commented Mar 16, 2020

@eriknw Finished removing references to Python 3.4 and fixed the pragma checks.

@eriknw
Copy link
Member

eriknw commented Mar 17, 2020

LGTM. Shall we merge? Thanks again for doing the heavy lifting and being patient and persistent.

@groutr
Copy link
Contributor Author

groutr commented Mar 17, 2020

I think this is in a merge-able state. There are some more things that I will do in another PR that will build off this.
Namely:

  1. In itertoolz.dissoc, use dict views instead of building a set. IIRC, this using views was a faster than creating the set (the set was required to make the code Python 2 compatible).
  2. Use yield from in places where it makes sense. This can provide a small performance increase in the cases where there are loops like
for item in seq
    yield item

@eriknw eriknw merged commit ea3ba0d into pytoolz:master Mar 17, 2020
@groutr groutr deleted the python3 branch March 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants