-
-
Notifications
You must be signed in to change notification settings - Fork 161
Update pytorch-lightning requirement from ==1.8.* to ==2.0.* #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version. - [Release notes](https://github.com/Lightning-AI/lightning/releases) - [Commits](Lightning-AI/pytorch-lightning@1.8.0rc0...2.0.1) --- updated-dependencies: - dependency-name: pytorch-lightning dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try this pinning @manujosephv 🐰
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
|
@Borda Does the new version not have I'm using a function here |
Since 1.9 it is named |
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
@Borda Some of the test case are still failing at the import |
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
|
@Borda Still failing. And its only on Ubunutu 20.04. Can't see the detailed logs for some reason. But previous fails were because of the new import. Can it be possible that in Ubuntu 20.04, 1.9 is not getting installed? |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on pytorch-lightning to permit the latest version.
Release notes
Sourced from pytorch-lightning's releases.
Commits
06032e8Update app CHANGELOG93d21edSimplifyrank_zero_experimentfortorch.compilesupport (#17216)7c65eeeDrop pre-commit from /requirements (#17049)637ac4bAvoidinference_modewithtorch.compile(#17215)a46b2b1Skip length checks for non-sized iterables (#17218)9a97fccGeneralizeOptimizervalidation to accommodate both FSDP 1.x and 2.x (#16733)6336d6aci/docs: wheels from cache (#17201)56b4dfdci: fix docs with caches (#17200)966c53bFix*_batch_endtypos (#17188)ebe97f8fix typo in docs migration 1_6_regular (#17186)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)📚 Documentation preview 📚: https://pytorch-tabular--181.org.readthedocs.build/en/181/
> **Note**