Skip to content

Conversation

@ProgramadorArtificial
Copy link
Contributor

@ProgramadorArtificial ProgramadorArtificial commented Jan 13, 2024

  • Corrected English mistakes
  • Fixed documentation structure
  • Fixed wrong default values in documentation

image


📚 Documentation preview 📚: https://pytorch-tabular--372.org.readthedocs.build/en/372/

@manujosephv
Copy link
Collaborator

manujosephv commented Jan 14, 2024

Thanks a lot @ProgramadorArtificial for these commits! They all look good and needed. Unfortunately, I pushed in a quite a bit of changes to the documentation yesterday. Can you rebase it to the latest commit and update the PR? Maybe also extend the english checks to the new documentation as well?

@ProgramadorArtificial
Copy link
Contributor Author

Hello, resolved conflicts :)

@manujosephv manujosephv merged commit 2ca211d into pytorch-tabular:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants