Add tuner return best model #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manujosephv
requested changes
Jan 14, 2024
| result = tabular_model_t.evaluate(validation, verbose=False) | ||
| params.update({k.replace("test_", ""): v for k, v in result[0].items()}) | ||
|
|
||
| if best_model is None: |
Collaborator
There was a problem hiding this comment.
Same as the other model sweep PR:
make tabular_model.datamodule = None before deep copying it, and as the end of the loop, set best_model.datamodule = tabular_model.datamodule`
Contributor
Author
There was a problem hiding this comment.
Changed.
tests/test_common.py
Outdated
| "optimizer_config__optimizer": ["RAdam", "AdamW"], | ||
| } | ||
| result = tuner.tune( | ||
| result, best_model = tuner.tune( |
Collaborator
There was a problem hiding this comment.
If we include best model in the namedtuple, we dont need to change this as well.
Contributor
Author
There was a problem hiding this comment.
Changed.
| "with warnings.catch_warnings():\n", | ||
| " warnings.simplefilter(\"ignore\")\n", | ||
| " result = tuner.tune(\n", | ||
| " result, best_model = tuner.tune(\n", |
Collaborator
There was a problem hiding this comment.
If we include best model in the namedtuple, we dont need to change this as well.
Contributor
Author
There was a problem hiding this comment.
Changed.
manujosephv
reviewed
Jan 14, 2024
manujosephv
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pytorch-tabular--374.org.readthedocs.build/en/374/