Skip to content

Add PyTorch 2.5 to regression test #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Add PyTorch 2.5 to regression test #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b1c40e7
add torch 2.5
gau-nernst Oct 17, 2024
42e6c70
remove torch 2.2
msaroufim Oct 17, 2024
e5ee557
Merge branch 'main' into torch2.5
gau-nernst Oct 18, 2024
ad70a22
use pypi
gau-nernst Oct 18, 2024
8f6fb82
skip tensor-parallel test on 2.5
gau-nernst Oct 18, 2024
5828901
skip low-bit optim FSDP2 test on 2.5
gau-nernst Oct 18, 2024
c4cf5b6
torch2.5 uses cuda12.4 on pypi
gau-nernst Oct 18, 2024
7d77856
use cu12.1 for torch2.5
gau-nernst Oct 18, 2024
749d9ba
Merge branch 'main' into torch2.5
gau-nernst Oct 21, 2024
475c5e9
re-apply version gating
gau-nernst Oct 21, 2024
728c2c4
fix galore dequant kernel
gau-nernst Oct 21, 2024
9a8319a
add mask for absmax load
gau-nernst Oct 21, 2024
3503d30
Merge branch 'main' into torch2.5
gau-nernst Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/regression_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ jobs:
fail-fast: false
matrix:
include:
- name: CUDA 2.2.2
runs-on: linux.g5.12xlarge.nvidia.gpu
torch-spec: 'torch==2.2.2 "numpy<2" '
gpu-arch-type: "cuda"
gpu-arch-version: "12.1"
- name: CUDA 2.3
runs-on: linux.g5.12xlarge.nvidia.gpu
torch-spec: 'torch==2.3.0'
Expand All @@ -38,17 +33,17 @@ jobs:
torch-spec: 'torch==2.4.0'
gpu-arch-type: "cuda"
gpu-arch-version: "12.1"
- name: CUDA 2.5
runs-on: linux.g5.12xlarge.nvidia.gpu
torch-spec: 'torch==2.5.0 --index-url https://download.pytorch.org/whl/cu121'
gpu-arch-type: "cuda"
gpu-arch-version: "12.1"
- name: CUDA Nightly
runs-on: linux.g5.12xlarge.nvidia.gpu
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cu121'
gpu-arch-type: "cuda"
gpu-arch-version: "12.1"

- name: CPU 2.2.2
runs-on: linux.4xlarge
torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu "numpy<2" '
gpu-arch-type: "cpu"
gpu-arch-version: ""
- name: CPU 2.3
runs-on: linux.4xlarge
torch-spec: 'torch==2.3.0 --index-url https://download.pytorch.org/whl/cpu'
Expand All @@ -59,6 +54,11 @@ jobs:
torch-spec: 'torch==2.4.0 --index-url https://download.pytorch.org/whl/cpu'
gpu-arch-type: "cpu"
gpu-arch-version: ""
- name: CPU 2.5
runs-on: linux.4xlarge
torch-spec: 'torch==2.5.0 --index-url https://download.pytorch.org/whl/cpu'
gpu-arch-type: "cpu"
gpu-arch-version: ""
- name: CPU Nightly
runs-on: linux.4xlarge
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cpu'
Expand Down
6 changes: 3 additions & 3 deletions test/dtypes/test_affine_quantized_tensor_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
)
from torchao.quantization.quant_api import quantize_
from torchao.dtypes import AffineQuantizedTensor
from torchao.utils import TORCH_VERSION_AT_LEAST_2_5
from torchao.utils import TORCH_VERSION_AT_LEAST_2_6

class TestAffineQuantizedTensorParallel(DTensorTestBase):
"""Basic test case for tensor subclasses
Expand Down Expand Up @@ -111,8 +111,8 @@ def forward(self, x: torch.Tensor) -> torch.Tensor:

y_d = dn_dist(up_dist(input_dtensor))

if not TORCH_VERSION_AT_LEAST_2_5:
# Need torch 2.5 to support compiled tensor parallelism
if not TORCH_VERSION_AT_LEAST_2_6:
# Need torch 2.6 to support compiled tensor parallelism
return

up_compiled = torch.compile(up_dist)
Expand Down
6 changes: 3 additions & 3 deletions torchao/testing/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from torchao.dtypes import to_affine_quantized_intx
from torchao.quantization.quant_primitives import MappingType
from torchao.quantization import quantize_, int8_weight_only
from torchao.utils import TORCH_VERSION_AT_LEAST_2_5
from torchao.utils import TORCH_VERSION_AT_LEAST_2_6

"""
How to use:
Expand Down Expand Up @@ -322,8 +322,8 @@ def forward(self, x: torch.Tensor) -> torch.Tensor:

y_d = dn_dist(up_dist(input_dtensor))

if not TORCH_VERSION_AT_LEAST_2_5:
# Need torch 2.5 to support compiled tensor parallelism
if not TORCH_VERSION_AT_LEAST_2_6:
# Need torch 2.6 to support compiled tensor parallelism
return

up_compiled = torch.compile(up_dist)
Expand Down
Loading