another fix for torch version #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `torch.__version__` has unexpected behavior when comparing to a string: ```python (Pdb) torch.__version__ '2.9.0.dev20250902+cu128' (Pdb) str(torch.__version__) '2.9.0.dev20250902+cu128' (Pdb) '2.9.0.dev20250902+cu128' >= '2.9' True (Pdb) torch.__version__ >= '2.9' False (Pdb) torch.__version__ >= (2, 9) False (Pdb) torch.__version__ >= (2, 9, 0) False (Pdb) str(torch.__version__) >= '2.9' True ``` To unblock the release, for now compare `str(torch.__version__)` to force the behavior we want for `torch==2.9.x`. We should make this more robust, saving that for a future PR. Test Plan: ``` 1. install torchao 0.13.0 from pip 2. install torch 2.8.0, verify torchao imports without errors 3. isntall torch 2.9.x, verify torchao imports correctly and a warning for skipping c++ kernel import is shown ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2922
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 9 PendingAs of commit 26f6546 with merge base f5a1d08 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
andrewor14
approved these changes
Sep 2, 2025
vkuzo
added a commit
that referenced
this pull request
Sep 2, 2025
Summary: `torch.__version__` has unexpected behavior when comparing to a string: ```python (Pdb) torch.__version__ '2.9.0.dev20250902+cu128' (Pdb) str(torch.__version__) '2.9.0.dev20250902+cu128' (Pdb) '2.9.0.dev20250902+cu128' >= '2.9' True (Pdb) torch.__version__ >= '2.9' False (Pdb) torch.__version__ >= (2, 9) False (Pdb) torch.__version__ >= (2, 9, 0) False (Pdb) str(torch.__version__) >= '2.9' True ``` To unblock the release, for now compare `str(torch.__version__)` to force the behavior we want for `torch==2.9.x`. We should make this more robust, saving that for a future PR. Test Plan: ``` 1. install torchao 0.13.0 from pip 2. install torch 2.8.0, verify torchao imports without errors 3. isntall torch 2.9.x, verify torchao imports correctly and a warning for skipping c++ kernel import is shown ``` Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torch.__version__has unexpected behavior when comparing to a string:To unblock the release, for now compare
str(torch.__version__)to force the behavior we want fortorch==2.9.x. We should make this more robust, saving that for a future PR.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: