Remove unused attributes in Float8Tensor #2935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att, hp_value_lb and hp_value_ub for weight are only used when calculating scale for the float8 tensor, doesn't have to be stored in the tensor itself. This PR removes it. We also have BC testing to make sure the change does not break BC. Test Plan: Regression tests: python test/integration/test_load_and_run_checkpoint.py Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2935
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3e153b0 with merge base f35ae41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jerryzh168
added
topic: not user facing
jerryzh168
changed the title
vkuzo
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
hp_value_lbandhp_value_ubfor Float8 weight tensor are only used when calculating scale for the float8 tensor, doesn't have to be stored in the tensor itself. This PR removes it.We also have BC testing to make sure the change does not break BC.
Test Plan:
Regression tests:
python test/integration/test_load_and_run_checkpoint.py
Reviewers:
Subscribers:
Tasks:
Tags: