Delete copy of quantized SDPA in torchao/experimental #2952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2952
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a5939a3 with merge base f1acc1e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81640227 |
kimishpatel
approved these changes
Sep 6, 2025
Contributor
kimishpatel
left a comment
kimishpatel
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 6, 2025
Summary: X-link: pytorch/ao#2952 This deletes the SDPA/matmul kernels in torchao/experimental. These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: kimishpatel Differential Revision: D81640227 Pulled By: metascroy
metascroy
added a commit
to metascroy/ao
that referenced
this pull request
Sep 6, 2025
Summary: This deletes the SDPA/matmul kernels in torchao/experimental. These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands. X-link: pytorch/executorch#13924 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: kimishpatel Differential Revision: D81640227 Pulled By: metascroy
metascroy
force-pushed
the
export-D81640227
branch
from
74899a6 to
8bd0254
Compare
Summary: Pull Request resolved: pytorch#2952 This deletes the SDPA/matmul kernels in torchao/experimental. These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands. X-link: pytorch/executorch#13924 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: kimishpatel Differential Revision: D81640227 Pulled By: metascroy
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81640227 |
metascroy
force-pushed
the
export-D81640227
branch
from
8bd0254 to
a5939a3
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 6, 2025
Summary: X-link: pytorch/ao#2952 This deletes the SDPA/matmul kernels in torchao/experimental. These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands. Pull Request resolved: pytorch#13924 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: kimishpatel Differential Revision: D81640227 Pulled By: metascroy
metascroy
added
the
topic: not user facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This deletes the SDPA/matmul kernels in torchao/experimental.
These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.
X-link: pytorch/executorch#13924
Reviewed By: kimishpatel
Differential Revision: D81640227
Pulled By: metascroy