Add nvcc flags to explicitly build mxfp8 dim1 cast kernel for sm100a #2979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2932
I think we need to explicitly add the nvcc flags to build for sm100a in the extension itself. Right now, we check if the
build_for_sm100a
flag is true, which is set to true for cuda 12.8+, but we don't actually modify the nvcc args passed in to build the extension.Seems like building from source is accidentally working? Looking into this..
Test plan
building 'torchao.prototype.mxfp8_cuda' extension
logs but does NOT have this warning ("MXFP8 quantization requires SM90+ (Hopper) or SM100+ (Blackwell) architecture. Kernel will be disabled for this architecture."
) in it: https://github.com/pytorch/ao/actions/runs/17631942858/job/50100852741