Skip to content

Conversation

@jerryzh168
Copy link
Contributor

Summary:
This is accidently missed from #3133, adding it back

Test Plan:
tested with the same commands locally

sh eval.sh --eval_type mm_quality --model_ids google/gemma-3-12b-it --mm_tasks chartqa --model_type gemma3 --mm_eval_batch_size 32
sh eval.sh --eval_type mm_quality --model_ids google/gemma-3-12b-it --mm_tasks chartqa --model_type gemma3 --mm_eval_batch_size 32 --use_cache
sh summarize_results.sh --model_ids google/gemma-3-12b-it

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
This is accidently missed from #3133, adding it back

Test Plan:
tested with the same commands locally
```
sh eval.sh --eval_type mm_quality --model_ids google/gemma-3-12b-it --mm_tasks chartqa --model_type gemma3 --mm_eval_batch_size 32
sh eval.sh --eval_type mm_quality --model_ids google/gemma-3-12b-it --mm_tasks chartqa --model_type gemma3 --mm_eval_batch_size 32 --use_cache
sh summarize_results.sh --model_ids google/gemma-3-12b-it
```
Reviewers:

Subscribers:

Tasks:

Tags:
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3204

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 12 Pending, 1 Unrelated Failure

As of commit 8ac5a6e with merge base 2d8a4c1 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@jerryzh168 jerryzh168 requested a review from metascroy October 17, 2025 20:41
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 17, 2025
@jerryzh168 jerryzh168 merged commit ced6231 into main Oct 17, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants