fix mxfp8 matmul benchmark #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds padding to the scales to properly support shapes where M % 128 != 0 Test Plan: ``` python benchmarks/float8/bench_matmul.py --shape_gen_name custom --recipe mxfp8_cublas --M 17 --K 32 --N 16 ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3221
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 7 PendingAs of commit faec97a with merge base ca99c1c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added
the
topic: improvement
jerryzh168
approved these changes
Oct 21, 2025
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
only scale need to be padded?
Contributor
Author
this fix just aligns the benchmark to use the same padding as is used in the actual code in MXTensor, the benchmark was incorrect if M % 128 != 0 separately, we could also add padding to the underlying data - we can do this in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds padding to the scales to properly support shapes where M % 128 != 0
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: