Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 21, 2025

Summary:

Small refactor to enable user to pass in custom MKN to inference roofline script

Test Plan:

python benchmarks/float8/float8_inference_roofline.py
~/local/tmp/test.csv --recipe_name mxfp8_cublas --shape_gen_name custom
--M 3072 --K 3072 --N 3072

Reviewers:

Subscribers:

Tasks:

Tags:

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3224

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit 9a6cb7d with merge base 6452b4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@vkuzo vkuzo added topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 21, 2025
@vkuzo vkuzo force-pushed the 20251021_inference_mkn branch from da65807 to 8b9a096 Compare October 21, 2025 22:11
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
Summary:

Small refactor to enable user to pass in custom MKN to inference
roofline script

Test Plan:

```
python benchmarks/float8/float8_inference_roofline.py
~/local/tmp/test.csv --recipe_name mxfp8_cublas --shape_gen_name custom
--M 3072 --K 3072 --N 3072
```

Reviewers:

Subscribers:

Tasks:

Tags:
@vkuzo vkuzo force-pushed the 20251021_inference_mkn branch from 8b9a096 to 9a6cb7d Compare October 21, 2025 22:21
@vkuzo vkuzo merged commit beee153 into main Oct 21, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants