fix unit test to use no grad #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3283
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 1fa1253 with merge base 9266734 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
liangel-02
added
the
topic: not user facing
andrewor14
reviewed
Nov 3, 2025
|
|
||
| # Needed since changing args to function causes recompiles | ||
| torch._dynamo.config.cache_size_limit = 128 | ||
| torch.set_grad_enabled(False) |
Contributor
There was a problem hiding this comment.
I think this disables it for all the tests, that's why some unrelated optim tests are failing? Maybe we should scope it to within the specific float8 test that's failing? @liangel-02 @jerryzh168 what do you think
Contributor
There was a problem hiding this comment.
yeah I think we can put this in setUp of the test case
liangel-02
force-pushed
the
fix_unit_tests
branch
3 times, most recently
from
2f6ec9d to
97dc6cb
Compare
liangel-02
force-pushed
the
fix_unit_tests
branch
from
97dc6cb to
1fa1253
Compare
jerryzh168
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating tests to use no grad due to 166367 breaking CI. PR was since reverted but updating in anticipation of it relanding.
Test
python test/quantization/quantize_/workflows/float8/test_float8_tensor.py