-
Notifications
You must be signed in to change notification settings - Fork 375
Move float8_opaque_tensor to prototype #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3365
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20c6579 with merge base 257d18a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @Xia-Weiwen , can you help move these two int4 tensors as well:
|
@Xia-Weiwen if you mark this as bc-breaking, you'll need to write a bc-breaking note I think it's fine to skip as well since it's probably not widely used yet since it's relatively new, but adding a bc-breaking note sounds fine as well. |
Thanks for the heads up. To make things easier, let me just change the label to "not user facing". |
Sure. |
Hi @liangan1 Could you please take int4_plain_int32_tensor.py ? Thanks. |
|
@jerryzh168 int4 for xpu should be some mature features, I am not sure why we need to move it into the prototype? int4_plain_int32_tensor.py |
|
@liangan1 the context is that we are trying to make sure what is recommended and supported in torchao very clear, currently some of the APIs from our team we can have commitment to maintaining and we expect to see wide adoption as shown in https://github.com/pytorch/ao#stable-workflows, but we are unsure about others, so we want to clean this up and move all the other flows to prototype first. We can discuss how to graduate from prototype as a separate step. I also don't think there is a clearly defined process to graduate from prototype today. cc @vkuzo @danielvegamyhre I'll discuss with the team offline to see what is expected here if you'd like to keep this as a stable feature |
As the title