Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Nov 24, 2025

Summary:

  • Before, worst case: ~4 minutes
  • Before, best case: ~2 minutes
  • After: ~82 sec

Changes:

  1. test smaller shapes in triton kernel tests, sometimes the large
    shapes are expensive in local runs
  2. remove testing of mxfp4 + compile, it's really slow and not useful
    yet

Test Plan:

pytest test/prototype/mx_formats/ -s

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Nov 24, 2025
Summary:

* Before, worst case: ~4 minutes
* Before, best case: ~2 minutes
* After: ~82 sec

Changes:
1. test smaller shapes in triton kernel tests, sometimes the large
   shapes are expensive in local runs
2. remove testing of mxfp4 + compile, it's really slow and not useful
   yet

Test Plan:

```
pytest test/prototype/mx_formats/ -s
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 9e8313a
ghstack-comment-id: 3571962428
Pull-Request: #3383
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3383

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit d4f3b17 with merge base 5f33595 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2025
@vkuzo vkuzo changed the title 1/3 mx cleanup: speed up local test suite 3/x mx cleanup: speed up local test suite Nov 24, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Nov 24, 2025
@vkuzo vkuzo requested a review from jerryzh168 November 24, 2025 17:36
"scale_calculation_mode",
[
ScaleCalculationMode.FLOOR,
ScaleCalculationMode.CEIL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this removed because in practice we're only using floor and rceil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

CEIL is still tested for eager, this removes it from compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants