-
Notifications
You must be signed in to change notification settings - Fork 375
3/x mx cleanup: speed up local test suite #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/vkuzo/168/head
Are you sure you want to change the base?
Conversation
Summary: * Before, worst case: ~4 minutes * Before, best case: ~2 minutes * After: ~82 sec Changes: 1. test smaller shapes in triton kernel tests, sometimes the large shapes are expensive in local runs 2. remove testing of mxfp4 + compile, it's really slow and not useful yet Test Plan: ``` pytest test/prototype/mx_formats/ -s ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9e8313a ghstack-comment-id: 3571962428 Pull-Request: #3383
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3383
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit d4f3b17 with merge base 5f33595 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| "scale_calculation_mode", | ||
| [ | ||
| ScaleCalculationMode.FLOOR, | ||
| ScaleCalculationMode.CEIL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this removed because in practice we're only using floor and rceil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep!
CEIL is still tested for eager, this removes it from compile
Summary:
Changes:
shapes are expensive in local runs
yet
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: