Skip to content

[0.7.1] Revert CommonVoice changes and disallow download=True #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[0.7.1] Revert CommonVoice changes and disallow download=True #1070

wants to merge 3 commits into from

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Dec 7, 2020 •
edited
Loading

Split into #1074 #1076 #1076

This PR

When review, please look at the commits except the first revert commit and ignore the revert. Click here.

Note Changes to the default version of the dataset cv-corpus-4-2019-12-10 to cv-corpus-5.1-2020-06-22 is not documented anywhere in the original PR, so I kept it reverted. I do not think we should make such subtle change on minor release, but I am open to changing it too.

Note 2: Also changed the upstream PyTorch version to point the 1.7.1rc, which should have been added to release/0.7 but was missing somehow.

@mthrok mthrok changed the title Release/0.7 [0.7.1] Revert CommonVoice changes and disallow download=True Dec 7, 2020
@mthrok mthrok mentioned this pull request Dec 7, 2020
Closed
@mthrok
Copy link
Contributor Author

mthrok commented Dec 7, 2020 •
edited
Loading

Unrelated tests are failing, and somehow it is ignoring the config for release/0.7 and instead it's using upstream master (1.8.0). The tests for CommonVoice are passing, though
Fixed this by hard-coding the conda channel, which should have happened already on release branch.

Note that the correct set of tests are expected to run at #1055 once this is merged.

@mthrok mthrok marked this pull request as ready for review December 8, 2020 00:07
@mthrok mthrok closed this Dec 9, 2020
@mthrok mthrok deleted the release/0.7 branch December 11, 2020 19:49
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@jerryzh168 @ilia-cher
@IvanKobzarev @mrshenli @xta0 @rohan-varma @ezyang @guyang3532 @hritikbhandari @pritamdamania87 @pritamdamania
Add graph mode static quantization tutorial (pytorch#1070)
703c478 
* Add TorchScript fork/join tutorial

* Add note about zipfile format in serialization tutorial

* Profiler recipe (pytorch#1019)

* Profiler recipe

Summary:
Adding a recipe for profiler

Test Plan:
make html-noplot

* [mobile] Mobile Perf Recipe

* Minor syntax edits to mobile perf recipe

* Remove built files

* [android] android native app recipe

* [mobile_perf][recipe] Add ChannelsLast recommendation

* Adding distributed pipeline parallel tutorial

* Add async execution tutorials

* Fix code block in pipeline tutorial

* Adding an Overview Page for PyTorch Distributed (pytorch#1056)

* Adding an Overview Page for PyTorch Distributed

* Let existing PT Distributed tutorials link to the overview page

* Add a link to AMP

* Address Comments

* Remove unnecessary dist.barrier()

* [Mobile Perf Recipe] Add the benchmarking part for iOS (pytorch#1055)

* [Mobile Perf Recipe] Add the benchmarking part for iOS

* [Mobile Perf Recipe] Add the benchmarking part for iOS

Co-authored-by: Jessica Lin <jplin@fb.com>

* Graph mode static quantization tutorial

* RPC profiling recipe (pytorch#1068)

* Initial commit

* Update

* Complete most of recipe

* Add image

* Link image

* Remove extra file

* update

* Update

* update

* Push latest changes from master into release/1.6 (pytorch#1074)

* Update feature classification labels

* Update NVidia -> Nvidia

* Bring back default filename_pattern so that by default we run all galleries.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Add prototype_source directory

* Add prototype directory

* Add prototype

* Remove extra "done"

* Add REAME.txt

* Update for prototype instructions

* Update for prototype feature

* refine torchvision_tutorial doc for windows

* Update neural_style_tutorial.py (pytorch#1059)

Updated the mistake in the Loading Images Section.

* torch_script_custom_ops restructure (pytorch#1057)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Port custom ops tutorial to new registration API, increase testability.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Kill some other occurrences of RegisterOperators

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Update README.md

* Make torch_script_custom_classes tutorial runnable

I also fixed some warnings in the tutorial, and fixed some minor bitrot
(e.g., torch::script::Module to torch::jit::Module)

I also added some missing quotes around some bash expansions.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Update torch_script_custom_classes to use TORCH_LIBRARY (pytorch#1062)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Co-authored-by: Edward Z. Yang <ezyang@fb.com>
Co-authored-by: Yang Gu <yangu@microsoft.com>
Co-authored-by: Hritik Bhandari <bhandari.hritik@gmail.com>

* Tutorial for DDP + RPC (pytorch#1071)

* Update feature classification labels

* Update NVidia -> Nvidia

* Bring back default filename_pattern so that by default we run all galleries.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Tutorial for DDP + RPC.

Summary: Based on example from pytorch/examples#800

* Add to main section

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Added separate code file and used literalinclude

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Co-authored-by: Jessica Lin <jplin@fb.com>
Co-authored-by: Edward Z. Yang <ezyang@fb.com>
Co-authored-by: pritam <pritam.damania@fb.com>

* Make RPC profiling recipe into prototype tutorial (pytorch#1078)

* Add RPC tutorial

* Update to include recipes

* Graph mode static quantization tutorial

Co-authored-by: James Reed <jamesreed@fb.com>
Co-authored-by: Jessica Lin <jplin@fb.com>
Co-authored-by: ilia-cher <30845429+ilia-cher@users.noreply.github.com>
Co-authored-by: Ivan Kobzarev <ivankobzarev@fb.com>
Co-authored-by: Shen Li <shenli@devfair017.maas>
Co-authored-by: Shen Li <cs.shenli@gmail.com>
Co-authored-by: Tao Xu <taox@fb.com>
Co-authored-by: Rohan Varma <rvarm1@fb.com>
Co-authored-by: Edward Z. Yang <ezyang@fb.com>
Co-authored-by: Yang Gu <yangu@microsoft.com>
Co-authored-by: Hritik Bhandari <bhandari.hritik@gmail.com>
Co-authored-by: Pritam Damania <9958665+pritamdamania87@users.noreply.github.com>
Co-authored-by: pritam <pritam.damania@fb.com>
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
@AvisP
Added mps option in generate.py (pytorch#1070)
35eb814 
After training a model in Mac with mps option, when trying to run the generate script it is giving a Runtime error "Placeholder storage has not been allocated on MPS device". To avoid this issue, this change is made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mthrok @facebook-github-bot