Deprecate download/url args and add language arg in CommonVoice #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
common-voice-4
branch
from
3682039 to
d61d42b
Compare
|
Superseded by #1082 |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
scheduler.step() should not be called at the start of every epoch as of PyTorch 1.1.0. Instead it should be called after the optimizer has updated the weights (after optimizer.step() is called) Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
…ORCE (pytorch#1083) Replace list with deque to obtain O(1) time complexity of insertion at the beginning of the list of returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aftert #1080, this PR deprecates
downloadandurlarguments in CommonVoice and addlanguagefor replacement ofurlargument.See #1077 for the agenda.