-
Notifications
You must be signed in to change notification settings - Fork 730
Refactor F.lfilter
and F.*_biquad
autograd tests
#1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor F.lfilter
and F.*_biquad
autograd tests
#1438
Conversation
update to new version
Accommodate changes in lfilter
Rebase to master
Get synced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Although I like the thorough testing, it's hitting the CI job time out limit.
Can we reduce the time it requires for the test somehow?
Autograd tests are by nature expensive itself.
I think it's good enough to use only one value for central_freq
and Q
.
I could be wrong but it feels that 2
, 100
, 800
, 4000
, 8000
are in a safe range for gradient computation.
If it is around 0
, I would be more cautious. (but again, this is my intuition and not backed by any hard fact. So if you disagree, please let me know)
Things like const_skirt_gain
should be parameterized because that change the code execution path, and we want to cover all the path.
Sounds reasonable, I agree. |
Thanks! |
* Update pytorch_with_examples.rst * Update pytorch_with_examples.rst
Adopt the autograd test model from
transforms/autograd_test_impl.py
.Also add more combinations of testing parameters.