Add autograd test for T.MelScale #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
approved these changes
Apr 21, 2021
mthrok
suggested changes
Apr 21, 2021
| def test_melscale(self): | ||
| sample_rate = 8000 | ||
| transform = T.MelScale(sample_rate=sample_rate) | ||
| waveform = get_whitenoise(sample_rate=sample_rate, duration=0.05, n_channels=2) |
There was a problem hiding this comment.
The input to MelScale has to be spectrogram. Passing waveform here, the MelScale will work on a wrong dimension, so we need to generate spectrogram from waveform and set the proper parameters.
Something like this.
n_fft = 400
n_mels = n_fft // 2 + 1
transform = T.MelScale(sample_rate=sample_rate, n_mels=n_mels)
spec = get_spectrogram(
get_whitenoise(sample_rate=8000, duration=0.05, n_channels=2),
n_fft=n_fft, power=1)There was a problem hiding this comment.
Thanks for the review. To be honest I was not sure about this one.
mthrok
reviewed
Apr 22, 2021
| n_fft = 400 | ||
| n_mels = n_fft // 2 + 1 | ||
| transform = T.MelScale(sample_rate=sample_rate, n_mels=n_mels) | ||
| waveform = get_spectrogram( |
There was a problem hiding this comment.
Can you rename waveform to spectrogram or spec?
This might appear trivial, but this is rather important for readability.
|
Thanks for the reviews Gentlemen! |
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1414